Add a test case related to spreading objects#57642
Merged
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
RyanCavanaugh
approved these changes
Mar 4, 2024
Member
|
#53413 shouldn't have fixed anything, so I do wonder what the heck I did... |
Contributor
Author
|
@jakebailey the circularity was caused by subtype reduction - ur PR avoids it in certain cases and thus it accidentally~ fixed this issue |
Contributor
Author
|
I re-checked and at the time the circularity was encountered by the subtype reduction we can see those types when we get to your optimization: typeToString(getTypeOfSymbol(leftProp)) // Foo | Box
typeToString(rightType) // Foo | Box | undefinedSo it makes sense that we don't get to the circularity now since u avoid that subtype reduction based on this check: result.links.type = leftTypeWithoutUndefined === rightTypeWithoutUndefined ? leftType : getUnionType([leftType, rightTypeWithoutUndefined], UnionReduction.Subtype);I'd call it - "accidental but good" :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test case for #48178
it was fixed by #53413